Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update window title if necessary #1124

Merged
merged 1 commit into from
Jul 31, 2017

Conversation

1r0b1n0
Copy link
Contributor

@1r0b1n0 1r0b1n0 commented Jul 17, 2017

Hi,
On Ubuntu 16.04 (with the kde desktop environment from the kde backports ppa), moving the camera makes the taskbar freeze for several minutes (while using 100% CPU).
This happens because :
When the user does move/rotate the camera
-> the pitch/yaw/... properties are updated
-> setWindowModified( true ) is called to notify the qwidget some modifications are pending
-> in setWindowModified() Qt will update the title bar of the rviz window, to add the ' * '
The problem is that kde's task manager has a hard time processing "new window title" events at several hundred times per second, thus freezes.

This pull request fixes the issue on my system

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, but currently pr testing is broken (we're working on it). I'll wait for that to get fixed before merging.

Also, I'd recommend reporting that issue upstream. It shouldn't be so inefficient to update the Window title 😲

@dirk-thomas
Copy link
Contributor

@ros-pull-request-builder retest this please

1 similar comment
@dirk-thomas
Copy link
Contributor

@ros-pull-request-builder retest this please

@wjwwood wjwwood merged commit 2753be1 into ros-visualization:kinetic-devel Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants