Check for odometry quaternion normalization before display #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhood
approved these changes
Aug 10, 2017
There was a problem hiding this comment.
thanks for the fix, @sharst! I can confirm that this prevents the crash in #1137. The tolerance matches what was settled on in TF2.
|
Ideally we would factor out this logic so that it can be reused in other places (as with validate_floats.h). @sharst are you interested in doing that? otherwise this is still an incremental improvement. |
|
@dhood should we merge this as an incremental improvement and ticket the refactor? I'm just curious because I am looking at doing a release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1137