MONO8 transformer for point cloud plugin #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pr, we'll have a look asap. |
dhood
reviewed
Dec 11, 2017
| float b = rgb_lut[rgb & 0xff]; | ||
| float mono = 0.2989 * r + 0.5870 * g + 0.1140 * b; | ||
| iter->color.r = iter->color.g = iter->color.b = mono; | ||
| iter->color.a = 1.0f; |
There was a problem hiding this comment.
AFAICT the defaults for green and blue channels will be 1.0, so I would think we need to set them to mono here as well to get the greyscale result that you show in the screenshot from the initial post. However, your image seems to show the pointcloud displaying as expected only setting the red. I want to confirm that only setting the red is sufficient before approving this PR (@wkentaro I know it's been a while since this PR was opened but if you had a specific reason for only setting the red channel I am interested).
There was a problem hiding this comment.
Ah, I misread the line and it is setting all three.
130s
pushed a commit
to 130s/rviz
that referenced
this pull request
Aug 21, 2024
…atus (ros-visualization#1137) (ros-visualization#1145) Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit ad1990bfa180f39b4cf04116438453783bb125f9) Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
I need to overlay color point cloud on mono one.
For example, grasp point on sensor input.