Allow to use scroll buttons in QTabWidgets created by RViz

[VictorLamoine]

If you stack a lot of widgets inside RViz, the labels becomes hard to read like this:

Solutions:

• Use shorter tab names (+ a tooltip)
• Expand the tab so that labels becomes easy to read again:
  
• Allow to use scroll buttons in the QTabWidget:
  • (without scroll buttons)
  • (with scroll buttons)

Last solution is by far the best in my opinion.
I think one solution is to subclass the tab bar and add a right click action to choose between scroll buttons, no scroll buttons.

[VictorLamoine]

I can't find the code that manages that part. I searched for QTabWidget but it's only returning one results which is not what I'm looking for (src/rviz/add_display_dialog.cpp).

Which part of the RViz code manages the stacking/moving of whole RViz panels?

[wjwwood]

@VictorLamoine I believe it is just done by QtMainWindow (of which VisualizationFrame inherits

rviz/src/rviz/visualization_frame.h

Line 71 in fa59398

class VisualizationFrame : public QMainWindow, public WindowManagerInterface

). Maybe what you want is https://doc.qt.io/qt-5/qmainwindow.html#DockOption-enum?

[VictorLamoine]

Thanks @wjwwood, it helped me a lot because I did not know the "dock widget" names.

I made a test and this is exactly what I wanted:

Default behaviour

Don't elide text in QTabBar

Now I need to find a place/signal to put this code (each time a panel is added or moved); the code itself is very straightforward:

https://github.com/ros-visualization/rviz/compare/kinetic-devel...VictorLamoine:QTabWidget_elide?expand=1

[gavanderhoorn]

Diff without whitespace changes: https://github.com/ros-visualization/rviz/compare/kinetic-devel...VictorLamoine:QTabWidget_elide?w=1.