replace RenderPanel::sendMouseMoveEvent by using QWidget::setMouseTracking

[simonschmeisser]

rviz/src/rviz/render_panel.cpp

Line 91 in fa59398

connect( fake_mouse_move_event_timer_, SIGNAL( timeout() ), this, SLOT( sendMouseMoveEvent() ));

uses a timer (33ms!) to fake receiving mouse move events when there is no button pressed (for interactive markers for example). Is there a reason why we are not setting QWidget::setMouseTracking
http://doc.qt.io/qt-5/qwidget.html#mouseTracking-prop ?

I'll open a PR later if no one remembers why it is done this way

[dhood]

At first I wondered it if was a new addition to qt but it looks like it was available in at the time of the commit. This approach might be appropriate if we were trying to limit the callback frequency or something, but at 30Hz it doesn't look like the case 😄. So it seems safe to me to swap to using setMouseTracking(true) (unless @hersh happens to remember a reason why it wasn't appropriate, but we're going back quite some years now).

Perhaps the reason will reveal itself if/when you give it a shot @simonschmeisser 😉

[rhaschke]

@simonschmeisser, could you provide a PR for this please?