Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this commit cause some interactive marker not working #1178

Closed
zhuyiif opened this issue Dec 29, 2017 · 6 comments
Closed

this commit cause some interactive marker not working #1178

zhuyiif opened this issue Dec 29, 2017 · 6 comments

Comments

@zhuyiif
Copy link

zhuyiif commented Dec 29, 2017

this commit may be cause something wrong, 73ad3e1,
after I update rviz ,some interactive markers not working, even official tutorial e.g https://github.com/ros-visualization/visualization_tutorials.

@rhaschke
Copy link
Contributor

Indeed this breaks interactive markers of MoveIt! as well. Previously, rviz was sloppy about unnormalized unit quaternions. Now it rejects those markers. It would be nice to have a smooth transition phase, where a warning is generated, the quaternion is normalized and processed anyway.

@rhaschke
Copy link
Contributor

Actually, the offending PR is #1167.

@zhuyiif
Copy link
Author

zhuyiif commented Dec 29, 2017

thanks for quick response :)

@jecksonAD
Copy link

Did the problem actually fixed? Because i still cannot using the interative marker in Rviz after the update

@rhaschke
Copy link
Contributor

rhaschke commented Jan 9, 2018

The problem is fixed and a release candidate is available via ros-shadow-fixed.

@wjwwood
Copy link
Member

wjwwood commented May 10, 2018

Closing this assuming the issue was actually fixed by now. Please comment if that's not the case.

@wjwwood wjwwood closed this as completed May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants