-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate tf for tf2 #1236
Deprecate tf for tf2 #1236
Conversation
@IanTheEngineer FYI I plan on closing the other pr. Also, this will probably introduce a deprecation warning in moveit (sorry about that), but I'm happy to make a pr for that if you can point me to where you needed to change things there. The warnings are easy to either address or suppress. There are some examples above in the issue description. |
I'll also mention that for the changes to the Constructor of |
That makes sense. I’m out on vacation this week, but I’ll point you to the right spot to help suppress the deprecation warnings next week when I return (around 5/16). There’s only two lines in all of MoveIt using the FrameManager |
The CI looks good to me, the remaining failure is in |
I'll add an note on this wiki page when this is merged: |
Migration guide updated: https://wiki.ros.org/melodic/Migration#rviz |
This pr deprecates all of the interfaces in rviz which I believe need to be so that in a future version we can drop the dependency on tf completely.
The two main places where interfaces are disabled are:
VisualizationManager
: b1bb6a2FrameManager
: 7ee47f3I migrated the
MessageFilterDisplay
which is a base class that many display plugins inherit from and therefore most of them will require no changes at all. I also migrated a couple other displays to show how it can be done, but I just suppressed the rest of the displays that produced deprecation warnings because I wanted to give an example of how to do that and because the work to convert them can be deferred until we actually remove the dependency ontf
completely.Examples of migrating to
tf2
:MessageFilterDisplay
: 0f227e5DepthCloudDisplay
: 2dc400dExamples of suppressing the deprecation warnings:
GridCellsDisplay
: 89b51e7TFDisplay
: c7f6a4aThere are a few unrelated style/warnings related changes at the end, which I could separate if desired, but they're small and mostly only affect macOS.