Esc shortcut to leave fullscreen prevents canceling tools from working

[ipa-fez]

rviz/src/rviz/visualization_frame.cpp

Line 484 in 070835c

new QShortcut(Qt::Key_Escape, this, SLOT( exitFullScreen() ));

This QShortcut seems to prevent esc key-events from firing which means

rviz/src/rviz/tool_manager.cpp

Line 133 in 070835c

if( event->key() == Qt::Key_Escape )

never gets called, meaning that actions such as send goal or initial pose can no longer be aborted with esc.

[rhaschke]

I guess, this was fixed via your #1256? If not, reopen this issue and provide a more detailed error description.

[ipa-fez]

This isn't fixed by #1256 .

Here's what's happening:
Old behaviour:

• Press g to start "send goal" tool
• click and hold left mouse button to start the send goal action
• Press ESC to cancel the action without sending a goal

This no longer works now since the ESC key was bound to "exit full screen" in addition to "cancel current action" and the "exit fullscreen" behaviour seems to prevent the key event from propagating to the tools.

A workaround to cancel started actions right now is to press "I" to switch to the interaction tool which will also cancel a started "send goal" action without sending the goal.

Possible solutions would be to:

• Remove the ESC shortcut to leave fullscreen (leaving F11 as a toggle)
• Making sure the ESC key propagates to the tools so when rviz is not fullscreened, actions are canceled and when rviz is fullscreened, either exit fullscreen or both exit fullscreen and cancel any active actions.

[rhaschke]

Thanks for describing the issue in more detail. When do you think the old behavior was working?
According to the commit log, the ESC shortcut to leave fullscreen was introduced together with fullscreen mode in #1017. So I guess, you refer to a version w/o the fullscreen feature, i.e. before May 2017?

[ipa-fez]

Exactly, when the version with fullscreen support was released, the bug was introduced.