Replace display error assert with warning, fallback and error #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se mode, librviz does not segfault with a misconfigured DISPLAY env.
wjwwood
reviewed
Aug 22, 2018
|
|
||
| if (display == NULL) { | ||
| ROS_FATAL("Can't open default or :0 display. Try setting DISPLAY environment variable."); | ||
| std::runtime_error( "Can't open default or :0 display!\n"); |
There was a problem hiding this comment.
Also, it has an extra whitespace between the ( and the ".
|
This PR should be good now. |
rhaschke
pushed a commit
that referenced
this pull request
Mar 6, 2019
…t with warning, fallback and error (#1282) If DISPLAY environment variable is misconfigured, resulting in an invalid display pointer: - try opening the default display :0 - if that fails too, bailout with a fatal error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace assert with warning, fallback and error so that when in release mode, librviz does not segfault with a misconfigured DISPLAY env.
In our use of librviz, RenderSystem::setupDummyWindowId() was segfaulting since display was not set correctly. This will provide warnings, fallback and a useful error in such cases.