Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ICC profiles in PNG images to silent libpng errors #1304

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Remove ICC profiles in PNG images to silent libpng errors #1304

merged 1 commit into from
Nov 14, 2018

Conversation

VictorLamoine
Copy link
Contributor

Fixes #1302

@VictorLamoine
Copy link
Contributor Author

Friendly pi(n)g 🐷

wjwwood
wjwwood approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I don't have time to build it myself and see that the images still show correctly on my macbook, but I can try and do that leading up to a release instead.

@wjwwood wjwwood self-assigned this Nov 14, 2018
@wjwwood wjwwood merged commit b1628ac into ros-visualization:melodic-devel Nov 14, 2018
@VictorLamoine VictorLamoine deleted the libpng branch November 15, 2018 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@wjwwood wjwwood

Labels
enhancement needs back port needs forward port to ros2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VictorLamoine @wjwwood