Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a shortcut key to the Publish Point tool #1321

Conversation

DaikiMaekawa
Copy link
Contributor

No description provided.

@DaikiMaekawa
Copy link
Contributor Author

I often use the Publish Point to clean up a Point Cloud data with my private tool. A shortcut key makes me faster to do the same work.
If you think the PR helps others, please merge it.

@rhaschke
Copy link
Contributor

rhaschke commented Mar 6, 2019

The choice of c as a short cut for Publish Point seems weird.

@DaikiMaekawa
Copy link
Contributor Author

@rhaschke
OK, then which key do you think the best?
I picked c from click, and unfortunately p is already used for 2D Pose Estimate tool.

@beetleskin
Copy link

beetleskin commented Mar 12, 2019

I like c.

Is this automatically merged into melodic-devel?

@DaikiMaekawa
Copy link
Contributor Author

Is this automatically merged into melodic-devel?

I guess not.

@rhaschke Should I open the same PR onto the other distro's branches?

@rhaschke
Copy link
Contributor

No need to file a PR for Melodic.

@rhaschke rhaschke merged commit 8ca07e1 into ros-visualization:kinetic-devel Mar 29, 2019
@rhaschke rhaschke mentioned this pull request Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants