Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed joint display hierarchy in EffortDisplay #1323

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Fixed joint display hierarchy in EffortDisplay #1323

merged 1 commit into from
Mar 5, 2019

Conversation

d-walsh
Copy link
Contributor

@d-walsh d-walsh commented Jan 27, 2019

Moves all joint information into the Joints category.

@rhaschke
Copy link
Contributor

Could you please motivate this change?

@d-walsh
Copy link
Contributor Author

d-walsh commented Feb 18, 2019

@rhaschke The Joints category was unused previously:

screenshot from 2019-02-18 12-07-18

Now it is used:

screenshot from 2019-02-18 12-03-55

I believe it was a bug.

rhaschke
rhaschke approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. LGTM.

@rhaschke rhaschke merged commit 8c2febc into ros-visualization:kinetic-devel Mar 5, 2019
rhaschke pushed a commit that referenced this pull request Mar 6, 2019
@d-walsh @rhaschke
EffortDisplay: fixed joint display hierarchy (#1323)
3d0cff3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke approved these changes

Assignees
No one assigned
Labels
need feedback or more info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-walsh @rhaschke