Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression introduced in Debian Stretch #1352

Closed
rhaschke opened this issue Mar 14, 2019 · 1 comment
Closed

regression introduced in Debian Stretch #1352

rhaschke opened this issue Mar 14, 2019 · 1 comment
Assignees
@rhaschke
Labels
review

Comments

@rhaschke
Copy link
Contributor

#1317 introduced a regression on Debian Stretch, which obviously doesn't provide tinyxml2::XMLDocument::ErrorStr() yet. I see two options:

  • simple: remove the verbatim error string output, but only report the error code
  • more elaborate: distinguish available tinyxml2 versions and selectively use ErrorStr or not.

@wjwwood, which option do you prefer?
@rhaschke rhaschke mentioned this issue Mar 15, 2019
Merged
@ghost ghost added the review label Mar 15, 2019
@ghost ghost removed the in progress label Mar 16, 2019
@wjwwood
Copy link
Member

wjwwood commented Mar 17, 2019

Sorry, my answer was subtle, but in approving #1354 I implicitly was voting for the simple option.

@dseifert dseifert mentioned this issue Apr 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhaschke rhaschke

Labels
review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wjwwood @rhaschke @dhood