Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows][melodic] Fix the run_tests build breaks on Windows. #1356

Merged
merged 4 commits into from
Mar 19, 2019
Merged

[Windows][melodic] Fix the run_tests build breaks on Windows. #1356

merged 4 commits into from
Mar 19, 2019

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Mar 18, 2019

This change is fixing the run_tests build breaks when catkin_make run_tests on Windows. random doesn't exist on Windows so switch to C++ <random> library for better portability.

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve your variable naming.

src/test/send_images.cpp Outdated Show resolved Hide resolved
src/test/send_images.cpp Outdated Show resolved Hide resolved
src/test/send_images.cpp Outdated Show resolved Hide resolved
rhaschke and others added 3 commits March 19, 2019 09:03
Co-Authored-By: seanyen <seanyen@microsoft.com>
Co-Authored-By: seanyen <seanyen@microsoft.com>
Co-Authored-By: seanyen <seanyen@microsoft.com>
@seanyen
Copy link
Contributor Author

seanyen commented Mar 19, 2019

@rhaschke Thank for the feedbacks! Fixed the naming.

@rhaschke rhaschke merged commit 1b5064f into ros-visualization:melodic-devel Mar 19, 2019
@seanyen seanyen deleted the windows_port_test_build_fix branch April 12, 2019 20:52
@rhaschke rhaschke mentioned this pull request Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants