Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set alpha channel value of Axes and TF displays #1357

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

alspitz
Copy link
Contributor

@alspitz alspitz commented Mar 23, 2019

Description

This adds a property named alpha to the Axes and TF displays that
changes the alpha channel value of the axes colors.

An updateAlpha method is added to Axes so that TF display can easily
change the default alpha value of the axes.

The default axes colors in the Axes object are changed to be fields
instead of static objects so that different axes objects can have
different alpha values.

It may be useful to make partially transparent axes for visualization purposes.

I am happy to make any requested changes.

This adds a property named alpha to the Axes and TF displays that
changes the alpha channel value of the axes colors.

The updateAlpha method is added to Axes so that TF display can easily
change the default alpha value of the axes.

The default axes colors in the Axes object are changed to be fields
instead of static objects so that different axes objects can have
different alpha values.
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good to me. But, as this changes API, I'm afraid, this can go to the noetic-devel branch only.

@rhaschke rhaschke changed the base branch from melodic-devel to noetic-devel March 29, 2019 13:11
@rhaschke rhaschke merged commit a466750 into ros-visualization:noetic-devel Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants