Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sip bindings build directory into the build space. #1360

Merged
merged 2 commits into from
Mar 29, 2019

Conversation

mikepurvis
Copy link
Member

@mikepurvis mikepurvis commented Mar 28, 2019

This is a goofy one, but the "binary dir" specified in build_sip_binding function is not a place to put built binaries, it's a place to put generated source, object files, etc. These don't belong in the develspace, they belong in the build space. Removing the line causes it to fall back to just using PROJECT_BINARY_DIR, see:

https://github.com/ros-visualization/python_qt_binding/blob/0.3.3/cmake/sip_helper.cmake#L196-L198

In case there's any doubt, here's what it places in that location, in a sip/rviz_sip subdirectory:

Makefile                                 siplibrviz_siprvizPanelDockWidget.o
pyqtscripting.sbf                        siplibrviz_siprvizProperty.cpp
sipAPIlibrviz_sip.h                      siplibrviz_siprvizProperty.o
siplibrviz_sipcmodule.cpp                siplibrviz_siprvizTool.cpp
siplibrviz_sipcmodule.o                  siplibrviz_siprvizToolManager.cpp
siplibrviz_siprvizBoolProperty.cpp       siplibrviz_siprvizToolManager.o
siplibrviz_siprvizBoolProperty.o         siplibrviz_siprvizTool.o
siplibrviz_siprvizConfig.cpp             siplibrviz_siprvizViewController.cpp
siplibrviz_siprvizConfigMapIterator.cpp  siplibrviz_siprvizViewController.o
siplibrviz_siprvizConfigMapIterator.o    siplibrviz_siprvizViewManager.cpp
siplibrviz_siprvizConfig.o               siplibrviz_siprvizViewManager.o
siplibrviz_siprviz.cpp                   siplibrviz_siprvizVisualizationFrame.cpp
siplibrviz_siprvizDisplay.cpp            siplibrviz_siprvizVisualizationFrame.o
siplibrviz_siprvizDisplayGroup.cpp       siplibrviz_siprvizVisualizationManager.cpp
siplibrviz_siprvizDisplayGroup.o         siplibrviz_siprvizVisualizationManager.o
siplibrviz_siprvizDisplay.o              siplibrviz_siprvizYamlConfigReader.cpp
siplibrviz_siprviz.o                     siplibrviz_siprvizYamlConfigReader.o
siplibrviz_siprvizOgreLogging.cpp        siplibrviz_siprvizYamlConfigWriter.cpp
siplibrviz_siprvizOgreLogging.o          siplibrviz_siprvizYamlConfigWriter.o
siplibrviz_siprvizPanelDockWidget.cpp

@rhaschke rhaschke merged commit 0aba661 into ros-visualization:melodic-devel Mar 29, 2019
@mikepurvis
Copy link
Member Author

Thanks!

@rhaschke rhaschke mentioned this pull request Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants