Ignore special conditions when normalizing image #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on the integration between Ignition and ROS (gazebosim/ros_gz#15), we ran into an issue where depth images were not properly displayed on RViz.
This PR makes sure that REP 117 is followed, and values like NaN and +-inf are ignored when normalizing depth images.
Without this PR, images containing NaN / Inf display completely black when "Normalize" is checked, because those values are used to calculate the normalization boundaries. With this PR, depth images coming from ign-sensors and relayed through the ros1_ign_bridge display correctly, as shown below: