Overload FailedDisplay::save for proper override #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid ABI braking Fix ros-visualization#1390 Signed-off-by: artivis <jeremie.deray@canonical.com>
rhaschke
reviewed
Aug 27, 2019
src/rviz/failed_display.cpp
Outdated
| @@ -70,6 +70,11 @@ void FailedDisplay::load( const Config& config ) | |||
| } | |||
|
|
|||
| void FailedDisplay::save( Config config ) | |||
| { | |||
| save(config); | |||
There was a problem hiding this comment.
Shouldn't this use a const_cast for this to actually redirect to the const-version and avoid an infinite loop?
There was a problem hiding this comment.
@rhaschke Thanks for pointing this out, fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overload
FailedDisplay::savefor properly overridingDisplay::savewithout breaking ABI.Fix #1390