Fix several issues with Camera and Image display #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove redundancies - "Camera Info OK", although never received - unify wording
... also when clearing tf_filter_ in reset() Otherwise received messages might be reported, which were outdated.
Property::load() first loads value "Value", which triggers enabling of the display if true. However, at that time, none of the parameters are loaded yet.
This resolves several open issues of displays with associated widgets (e.g. Camera and Image). - when minimizing / unminimizing the main window, the enabled status of those displays changed - tabbed DockWidgets were closed (and couldn't easily be reopened by enabling the display)
rhaschke
force-pushed
the
fix-camera-image
branch
from
aea864d to
b6362c1
Compare
rhaschke
force-pushed
the
fix-camera-image
branch
2 times, most recently
from
cafa965 to
b6362c1
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several, partially long-standing, issues with Camera and Image display. See individual commit messages for details.
Fixes #940
Fixes #1368
Unfortunately, the current, "clean" implementation requires an ABI change.
But I added an ABI compatible solution, using a global map to store the new member instead.