Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rviz -d xyz could look for ~/.rviz/xyz.rviz if xyz does not exist? [feature request] #1420

Closed
v4hn opened this issue Sep 5, 2019 · 3 comments

Comments

@v4hn
Copy link
Contributor

v4hn commented Sep 5, 2019

This is just a minor potential usability improvement I came up with recently.
I use rviz -d /path/to/file.rviz quite a lot these days, working on a machine with multiple users of rviz.

Of course, this can be automated in a number of ways already, creating a shell alias, scripts or setup a launch file, but why not support the use-case in RViz directly?

Would it be a welcome feature in RViz to complete rviz -d xyz to rviz -d $HOME/.rviz/xyz.rviz if the original xyz is no valid file?

@rhaschke
Copy link
Contributor

rhaschke commented Sep 6, 2019

Why not. If you have it prepared already, please file a PR.

@v4hn
Copy link
Contributor Author

v4hn commented Sep 6, 2019

We work in different ways. 😀
I tend to ask whether it makes sense to write a patch for upstream before I invest the time to do it. ;)
I just wrote a patch and filed it as #1422

@rhaschke
Copy link
Contributor

rhaschke commented Sep 8, 2019

Fixed via #1422.

@rhaschke rhaschke closed this as completed Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants