Fix sphere being off centre, smooth cube #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
pushed a commit
to rhaschke/rviz
that referenced
this pull request
Mar 31, 2020
* Update rviz_sphere.mesh with fixed centre. Fixup for 2cf0b24 * Update rviz_cube.mesh with fixed normals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1485 (sphere being off centre). I have also added a smooth cube which was not included in the original PR.
Original sphere (e.g.
kinetic-devel)Sphere in current
melodic-devel(which is off-centre)Fixed sphere in this PR
Current cube
New cube