fix initial pose and goal buttons

[doisyg]

Fix #1509
The wrong TF2 conversion was used

[rhaschke]

Can you explain a little bit more, what is wrong with tf2::convert? Shouldn't that work as well?

[doisyg]

http://docs.ros.org/noetic/api/tf2/html/namespacetf2.html#af1255c37833c838543b512febce5e9b1
http://wiki.ros.org/tf2/Tutorials/Quaternions

void tf2::convert ( const A &  a,  B & b ) 
a | an object to convert from
b | the object to convert to

a and b were inverted, quat_msg = tf2::toMsg(quat_tf) does the same and has the advantage of being less ambiguous

[doisyg]

But I will happily fix it using convert the other way around if preferred

[rhaschke]

I see. Thanks for clarification.
There might be other places in the rviz code base using tf2::convert in the wrong order. It would be great, if you could check (and fix) them as well. I prefer the less ambiguous toMsg() / fromMsg() too. Thanks for your help!

[doisyg]

tf2::convert is also used in https://github.com/ros-visualization/rviz/blob/noetic-devel/src/test/rviz_logo_marker.cpp and https://github.com/ros-visualization/rviz/blob/noetic-devel/src/test/marker_test.cpp, but properly I believe

[rhaschke]

Just to improve readability / reduce ambiguity, I would appreciate it if you could replace those instances as well.

[doisyg]

Done

[rhaschke]

Could you please fix the clang-format issues indicated by Travis yourself here?

[rhaschke]

Thanks a lot.