Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't select interactive markers #1527

Closed
wolfv opened this issue Jul 22, 2020 · 3 comments
Closed

Can't select interactive markers #1527

wolfv opened this issue Jul 22, 2020 · 3 comments

Comments

@wolfv
Copy link
Contributor

wolfv commented Jul 22, 2020

The PR of #1519 in release 1.13.13 brea makes RViz unable to select interactive marker arrows for me (cf. ros-visualization/interactive_markers#76)

replacing the size==3 case with:

      else { // otherwise perform "official" transformation into float-based Ogre::ColourValue and back
        uint32_t pos = (x + y * w) * 3;
        uint8_t* data = (uint8_t*)box.data + pos;
        uint32_t pix_val = 0;
        memcpy((uint8_t*)&pix_val, (uint8_t*)box.data + pos, 3);
        pixels.push_back(colorToHandle(box.format, pix_val));
      }

works fine.

The conversion to float is probably (too) lossy.

@rhaschke
Copy link
Contributor

Please file a PR if this fixes your issue. Thanks for debugging.

@wolfv
Copy link
Contributor Author

wolfv commented Jul 22, 2020

I did that: #1528

Thanks for the awesome RViz work!

@rhaschke
Copy link
Contributor

Closed via #1528. Sorry, I didn't notice the PR in first place. Thanks for your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants