Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce GLSL 1.4 on more Mesa systems (#1559) #1588

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

rhaschke
Copy link
Contributor

Mesa-based rendering issues showed up e.g. on AMD GPU as well. The new approach should handle any Mesa 20-based system.
Fixes #1584.

@peci1
Copy link
Contributor

peci1 commented Mar 19, 2021

@rhaschke Also an AMD cpu here. However, for compatibility with the pretty new hardware, I installed Mesa from kisak-mesa PPA. That PPA provides Mesa 21.0, so the fix used here won't work for me. Passing --opengl 310 to rviz fixes it, but it would be nice to have it working by default.

GL_RENDERER   = AMD RENOIR (DRM 3.40.0, 5.10.24-051024-generic, LLVM 11.0.1)
GL_VERSION    = 4.6 (Compatibility Profile) Mesa 21.0.0 - kisak-mesa PPA
GL_VENDOR     = AMD

Should I submit a melodic-devel PR that would enable the workaround for any 2x.y Mesa?

@rhaschke
Copy link
Contributor Author

Should I submit a melodic-devel PR that would enable the workaround for any 2x.y Mesa?

Yes, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rviz segfaults on pointclou2 with new opengl
2 participants