Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new imagepanel, but it doesn't display correctly. #1605 #1611

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

jeffryHo
Copy link
Contributor

@jeffryHo jeffryHo commented Apr 8, 2021

Description

#1605

Fix add a new image panel but it's image didn't display correctly problem.

Checklist

  • If you are addressing rendering issues, please provide:
    • Images of both, broken and fixed renderings.
    • Source code to reproduce the issue, e.g. a YAML or rosbag file with a MarkerArray msg.
  • If you are changing GUI, please include screenshots showing how things looked before and after.
  • Choose the proper target branch: latest release branch, for non-ABI-breaking changes, future release branch otherwise.
    Due to the lack of active maintainers, we cannot provide support for older release branches anymore.
  • Did you change how RViz works? Added new functionality? Do not forget to update the tutorials and/or documentation on the ROS wiki
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers of RViz. Refer to the RViz Wiki for reviewing guidelines.

@rhaschke rhaschke merged commit 757b445 into ros-visualization:melodic-devel Apr 8, 2021
@rhaschke
Copy link
Contributor

rhaschke commented Apr 8, 2021

Thanks for your contribution! Next time, please use a more informative main description for the PR.

@jeffryHo
Copy link
Contributor Author

jeffryHo commented Apr 9, 2021

Thanks for merged my PR, I found that you changed the setting of floating, but when floating is set to true, the panel cannot be displayed because you did not add the panel to the main window. Have you ever tested it?

if floating is true then rviz show like this
1

When the PanelDockwidget is created, its parent class is not specified.

I don't understand what you mean "floating" mutually excludes "docked"? After addDockWidget you can also make the widow floating.

@rhaschke
Copy link
Contributor

rhaschke commented Apr 9, 2021

I'm sorry. I didn't explicitly test floating=true. I was assuming that a floating DockWidget shouldn't require a prior call to addDockWidget(), because it will not be docked. I pushed a fixup commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants