Smoothly update pose of point cloud on update() #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
force-pushed
the
melodic-devel
branch
from
2dc6ae4 to
ab4d3aa
Compare
rhaschke
force-pushed
the
melodic-devel
branch
from
b161446 to
a6e58df
Compare
|
I had to revert this PR due to issues in normal uses cases: #1666. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the migration of #1652 to the
melodicbranch. The PR addresses the problem that a point cloud isn't smoothly moving if itsframe_idis moving w.r.t. rviz' fixed frame.The solution was to update the pose of the corresponding scene node in each
update()cycle, not only when the message was received.