-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marker load mesh resource success, but not show in window? #1665
Comments
Does it work in a non-WSL environment? If so, I suspect the WSL environment. |
I don’t have a physical machine, I test shape, boxes, e.g. All this can be displayed normally. |
Did you try another mesh as well? |
Closing due to missing feedback and because the issue isn't reproducible on default platforms. |
I guess this is due to using a non-English locale which does not have decimal point but e.g. decimal comma (as my cs_CZ happens to have, too). I confirm that running rviz with my czech locale, objects smaller than 1 meter (before scaling) are not shown at all as rviz reads Try running rviz with These locale-dependent problems are ever-occuring in both RViz and Gazebo. Wouldn't it be easier to set locale to English right after starting RViz? There's anyways no translation of it, so the only difference would be that users would see floating point numbers in the property tree rendered in English locale instead of their own (which I'd consider a feature and not a problem). |
After some discussion in #1682 I suggest to reopen this bug (although I face it on Melodic).
Nope, I run on binary packages from APT... The latest update of liburdfdom-dev on my system was in February 2021, so this should not be the cause (although I can't say for how long have I not used custom mesh markers). |
urdfdom should not be involved here at all actually as we talk about markers. But they are certainly not the only ones using those innocent looking functions ... |
@peci1, could you please provide more details about your setup as well as your marker mesh file? Thanks. |
Ubuntu 18.04 on x86_64, ROS Melodic from APT binary packages (including rviz).
|
Here are the meshes I'm trying to visualize meshes.zip. For example:
|
@peci1, your meshes are broken, requiring a pre-open interaction, e.g. when opening in meshlab: |
@peci1, can you please check again, if you can reproduce the locale issue by some other means? |
Localization environment is zh-Hans or zh-CN(Simplified Chinese) in the scene I encountered. |
My Rviz doesn't have the problems with opening the marker: with The fact that Meshlab asks for what geometry nodes to display is pretty normal with Collada. I don't remember a single time when it would just open a Collada file without askin. These meshes work pretty normally in Gazebo. |
I'll try to construct a simple mesh that manifests the problem, too. |
Even this super-simple blender-exported cube manifests the problem: box.zip. What's interesting is that when I change |
@thinkershare Can you check the units of the meshes you try to display? |
Meshes could be loaded via assimp, using the github search (very unreliable) tells me that only colors for X3D files should be broken in assimp on non English locales but no further use of rviz also does some collada parsing here: Line 634 in 45e5a9b
|
Very good intuition! I just tested it and |
This uses tinyxml2 which boils down to Basically TinyXml(2) is broken and in other places the argument is read as string and then parsed manually: |
Fix in #1684. @thinkershare Can you confirm this fix fixes your issue, too? |
Yes, now it works fine. |
Fixed via #1685. |
Environment:
The text was updated successfully, but these errors were encountered: