-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service load_config_discard_changes #1710
Add service load_config_discard_changes #1710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. Given that this targets an already released distro, I agree with your choice of using another service name. Otherwise, the existing message should have been augmented by an extra flag.
Please address the two minor comments below.
Thanks for the speedy reply and review. Your comments have been addressed in the latest commits. Do I need to do anything about the failing CI jobs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more nitpicks.
Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
…nto load-config-discard-changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. I'm happy if CI is...
Description
Adds a service
load_config_discard_changes
that avoids the "There are unsaved changes" dialogue that appears when calling the regularload_config
service.I am very open to alternative names for the service, and alternative implementations.
Implements suggestions in #1709
Checklist
YAML
orrosbag
file with aMarkerArray
msg.Due to the lack of active maintainers, we cannot provide support for older release branches anymore.