RobotLink: Simplify material mode handling #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
force-pushed
the
simplify-material-switching
branch
from
8169864 to
4f1ead7
Compare
|
Closing and reopening to trigger CI. |
rviz::RobotLink knows 3 material modes, showing: - original material of the mesh - a user-selected color - an error color (uniform white) Switching between these modes requires iterating through all subentities of the link, which might be rather time-consuming. Also, this was done in each update() cycle! This commit simplifies the handling, performing the costly update only if really necessary.
rhaschke
force-pushed
the
simplify-material-switching
branch
from
4f1ead7 to
2857811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rviz::RobotLink knows 3 material modes, showing:
Switching between these modes requires iterating through all subentities of the link,
which might be rather time-consuming. Also, this was done in each update() cycle!
This commit simplifies the handling, performing the costly update only if really necessary.