Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace obsolete QPixmap::grabWindow() with QScreen::grabWindow() #1794

Merged
merged 2 commits into from
May 10, 2023

Conversation

vineet131
Copy link
Contributor

@vineet131 vineet131 commented May 9, 2023

Referring to the document below and based on the warnings I am getting at runtime, we replace QPixmap with QScreen:
https://doc.qt.io/qt-5/qpixmap-obsolete.html

Description

Referring to the document below and based on the warnings I am getting at runtime, we replace QPixmap with QScreen:
https://doc.qt.io/qt-5/qpixmap-obsolete.html

Checklist

  • If you are addressing rendering issues, please provide:
    • Images of both, broken and fixed renderings.
    • Source code to reproduce the issue, e.g. a YAML or rosbag file with a MarkerArray msg.
  • If you are changing GUI, please include screenshots showing how things looked before and after.
    (Unfortunately I am running this on Ubuntu 22.04 right now, and not my work PC where I was getting the error, and cannot compile ROS1 code here. How do I proceed?)
  • Choose the proper target branch: latest release branch, for non-ABI-breaking changes, future release branch otherwise.
    Due to the lack of active maintainers, we cannot provide support for older release branches anymore.
  • Did you change how RViz works? Added new functionality? Do not forget to update the tutorials and/or documentation on the ROS wiki
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers of RViz. Refer to the RViz Wiki for reviewing guidelines.

vineet131 and others added 2 commits May 9, 2023 23:37
Referring to the document below and based on the warnings I am getting at
runtime, we replace QPixmap with QScreen:
https://doc.qt.io/qt-5/qpixmap-obsolete.html
@rhaschke
Copy link
Contributor

Thanks for pointing out this deprecation in newer versions of Qt5. Unfortunately, this PR didn't even compile as is.

@vineet131
Copy link
Contributor Author

Thanks for pointing out this deprecation in newer versions of Qt5. Unfortunately, this PR didn't even compile as is.

Thanks for the fixup. I couldn't compile it at home since I am not running ROS1 at home.

@rhaschke rhaschke merged commit 10cb16e into ros-visualization:noetic-devel May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants