Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggle fullscreen button for ImageDisplay #1803

Merged

Conversation

rhaschke
Copy link
Contributor

implementation for #1802

@rhaschke rhaschke force-pushed the image-display-full-screen branch from b2578cc to 697194c Compare September 16, 2023 09:15
@rhaschke rhaschke marked this pull request as ready for review April 17, 2024 09:34
@rhaschke rhaschke merged commit 6ca7e79 into ros-visualization:noetic-devel Apr 17, 2024
8 of 9 checks passed
@rhaschke rhaschke deleted the image-display-full-screen branch April 17, 2024 11:36
@peci1
Copy link
Contributor

peci1 commented May 9, 2024

With a single display, it works well. However, it struggles on my multi-monitor setup:

image_maximize.mp4

You can see the behavior is not consistent on multiple retries.

My monitor setup:

Snímek obrazovky pořízený 2024-05-09 14-39-01

xrandr excerpt:

Screen 0: minimum 320 x 200, current 3120 x 2451, maximum 16384 x 16384
eDP connected 1920x1080+1200+1371 (normal left inverted right x axis y axis) 309mm x 173mm
...
DisplayPort-5 connected primary 1920x1200+1200+171 (normal left inverted right x axis y axis) 518mm x 324mm
...
DisplayPort-9 connected 1200x1920+0+0 left (normal left inverted right x axis y axis) 518mm x 324mm
...

The same happens even when I align the top of display 2 with the top of display 3.

@rhaschke
Copy link
Contributor Author

rhaschke commented May 9, 2024

@peci1, I'm afraid that's an Qt issue (which we cannot resolve).

@peci1
Copy link
Contributor

peci1 commented May 9, 2024

Okay, it's nothing horrible ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants