Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply colour to all visuals of the line class #827

Merged
merged 1 commit into from
Nov 20, 2014
Merged

Apply colour to all visuals of the line class #827

merged 1 commit into from
Nov 20, 2014

Conversation

stonier
Copy link
Contributor

@stonier stonier commented Nov 15, 2014

This allows setting of the colour properties for a line in rviz (currently doesn't work). Refer to discussion in #820.

@wjwwood
Copy link
Member

wjwwood commented Nov 18, 2014

Thanks for putting this in a pull request @stonier, as I stated in #820 I don't know if this is the right solution, maybe @hersh or @acornacorn or even @dgossow might have some time to look at it/insight into what the correct solution would be.

@hersh
Copy link
Contributor

hersh commented Nov 18, 2014

I'm fine with it if it looks good. There are other examples of setting colors in rviz, and they do something like set one type of color to rgb and the other to rgb/2 or something. I don't think it will hurt anything regardless, especially if the old version doesn't work.

@wjwwood
Copy link
Member

wjwwood commented Nov 19, 2014

I wonder if it should not be more like this setColor in shape.cpp:

https://github.com/stonier/rviz/blob/line_visualization/src/rviz/ogre_helpers/shape.cpp#L125-140

@hersh
Copy link
Contributor

hersh commented Nov 19, 2014

@wjwwood probably so, yes. :)

@stonier
Copy link
Contributor Author

stonier commented Nov 20, 2014

From Shape - it's the american revolution II! :neckbeard:

void Line::setColor( const Ogre::ColourValue& c )

I updated for consistency across shape and line. Tested and seems fine.

@wjwwood
Copy link
Member

wjwwood commented Nov 20, 2014

Awesome, lgtm.

wjwwood added a commit that referenced this pull request Nov 20, 2014
Apply colour to all visuals of the line class
@wjwwood wjwwood merged commit 923d86c into ros-visualization:indigo-devel Nov 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants