Allow force and torque in Wrench to be scaled separately #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, the changes look ok, but I'm going to release any more Groovy versions of rviz. Can you please open the pull request against the |
|
+1 |
|
I'm going to merge this into groovy-devel, but I will not be releasing a new version. |
wjwwood
added a commit
that referenced
this pull request
Apr 2, 2015
Allow force and torque in Wrench to be scaled separately
wjwwood
added a commit
that referenced
this pull request
Apr 2, 2015
…g_indigo Forward port of pull request #862 to indigo-devel
|
And we'll have to forward-port it to latest versions, right?
|
|
Yeah, #870 is for indigo, I'll back port to hydro when I do the next release. |
|
I also back ported @chapulina's commit fixing the indention up: d24eadc |
|
Thank you so much! |
130s
pushed a commit
to 130s/rviz
that referenced
this pull request
Aug 21, 2024
…ization#867) These resource files support relative paths from their directory, so we should override the default paths for UNIX and WIN32 to act like APPLE, where relative paths are used by default. This should be a pretty safe thing to do because the absolute paths currently in these locations are actually to the staging in the project's build directory, which isn't available unless building from source. Signed-off-by: Scott K Logan <logans@cottsay.net> (cherry picked from commit 5c54f57ba409b1a096f9310a9b75d67731137b39) Co-authored-by: Scott K Logan <logans@cottsay.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since force and torque are different quantities, the units of their scalings are different (meters per Newton and meters per Newton-meter, respectively), and so they should really have separate scalings. Practically, the torques in my Wrench are usually much smaller than the forces if I use the same scaling.
I am on Groovy, but it looks like this patch can apply to all releases up to present.