Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist which marker namespaces were visible #953

Closed
stuglaser opened this issue Dec 12, 2015 · 5 comments
Closed

Persist which marker namespaces were visible #953

stuglaser opened this issue Dec 12, 2015 · 5 comments
Labels

Comments

@stuglaser
Copy link

In the Marker display type, you can click checkboxes to show or hide each namespace. If the time resets then this selection is lost and all marker namespaces become visible again.

It would be great if the selection of which are visible persisted when the time was reset. Even better if it persisted when rviz was restarted.

@wjwwood
Copy link
Member

wjwwood commented Mar 22, 2016

I believe this was fixed in #962. I'm going to close, please comment if you think it is still an issue.

@wjwwood wjwwood closed this as completed Mar 22, 2016
@stuglaser
Copy link
Author

It's nearly fixed. When you save the config and restart rviz the active namespaces persist. However, if time jumps backwards or if you click rviz's Reset button, then the active namespaces are reset.

cc @bponsler

@wjwwood
Copy link
Member

wjwwood commented Mar 22, 2016

I see, I'll reopen this for now then. Thanks.

@wjwwood wjwwood reopened this Mar 22, 2016
@wjwwood wjwwood added the bug label Mar 22, 2016
@wjwwood wjwwood modified the milestone: untargeted Mar 22, 2016
@bponsler
Copy link
Contributor

bponsler commented Apr 7, 2016

I just created PR #988 to keep the marker display plugin from erasing the map of enabled namespaces when the reset button is pressed. I did the same for the tf plugin. Both plugins were also updated to update the map of enabled frames as the frames are enabled/disabled using the UI check boxes so that the reset button does not return to the original state of the configuration file but instead keeps whatever namespaces/frames are enabled when the reset happens.

I think these changes will solve this issue.

@wjwwood
Copy link
Member

wjwwood commented Apr 7, 2016

Closed by #988

@wjwwood wjwwood closed this as completed Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants