prefix install target with project name #1019
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catkin_make
for rosserial fails to build with the current Windows wrapper implementation:this issue exists because
catkin_make
treats the entire workspace as a single project (all projects as subfolders), and so the Windows wrapper for_setup_util.py
gets redefined for multiple times, leading to name collision. Since this leads to a fatal error message, it would terminate the build and break the entire building experiencewhile
catkin_make
is gradually getting retired, this change would still be needed as maintenance for existing CLI interface. Meantime, pre-pending with${PROJECT_NAME}
would not cause any trouble for thecatkin_make_isolated
usagerelated issue: ms-iot/ROSOnWindows#94
related ros.answers discussion: https://answers.ros.org/question/320613/catkin_make-vs-catkin_make_isolated-which-is-preferred/