[Windows][noetic-devel] Generate executables without extension name. #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dirk-thomas This is ready for review and merge. Thanks! |
dirk-thomas
requested changes
Feb 6, 2020
|
Thanks for the patch. |
dirk-thomas
approved these changes
Feb 6, 2020
dirk-thomas
pushed a commit
that referenced
this pull request
Feb 6, 2020
…1061) * generate exe without extension name. * use NAME_WE to be compatible with CMake<3.14. * Fixed the wrong reference.
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For scripts ending with
.py,add_python_executablewill take the full filename (e.g.,abc.py) and produce the executable ending with.py.exe(e.g.,abc.py.exe) and which is not the expected script alias.The pull request is proposing to extract the filename without the last extension by using
NAME_WLEfirst and then generate the correct executable with the name without the extra.py.And it would be great this can be backport to
kineticbranch. Thanks!