[Windows][noetic] a follow up fix to the generated executable change. #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dirk-thomas This is ready for review and merge. Thanks! |
|
Why should the code need to guess? The script name is known at configure time - if it does or does not contain a |
|
@dirk-thomas Sure, I changed the template |
|
Thanks for the patch. |
dirk-thomas
pushed a commit
that referenced
this pull request
Feb 8, 2020
…#1063) * a follow up fix to the generated exectuable change. * address the feedback.
|
Also cherry-picked to |
|
@dirk-thomas Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After more validation to my earlier changes of "Generate executables without extension name", I overlooked a required change in
python_win32_wrapper.cpp.inside. Please excuse me causing any inconvenience.