fix GTest detection when cmake-extras is installed #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
deleted the
dirk-thomas/fix-gtest-detection-when-cmake-extras-installed
branch
|
Cherry-picked to |
dirk-thomas
added a commit
that referenced
this pull request
May 14, 2020
rhaschke
added a commit
to ubi-agni/catkin
that referenced
this pull request
Jul 1, 2020
This fixes ros#1091, which introduced a shortcut defining GTEST_FOUND when all targets are defined. However, those targets are defined by a previous source build of gtest and gmock as well. Hence, if another catkin package is build below the same top-level project, the corresponding GTEST_* variables were not defined anymore (because those values were not cached). g
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1084.