Add Arch Linux gtest path #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where are the headers located in the Arch package? I assume it is already covered by one the listed directories - it just might be worth to add a comment so that is isn't been broken in the future. |
|
Yeah I was going to put the header files in as well, but the path overlaps with the existing directories so I removed it. I'll add it back in as a comment. |
|
@dirk-thomas I have updated the PR with your suggestions. Let me know if I should be more descriptive. I think addition to the comment and the commented include path is suffice. |
|
Thanks for the pull request and the quick update. |
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1030
Debian installs gtest/googletest related files under
googletest/googletest/srcwhereas Arch Linux installs it under justgoogletest/src