[noetic-devel][Windows] Fix file COPY cannot read symlink #1109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change from #1100 introduced an usage of
file(COPY)
and unfortunately this idiom has some limitation on Windows. For example,CMake
doesn't support the case where the source file is a symlink, due to the absent ofReadSymlink
implementation on Windows.And when the conditions are met, it will render as errors like below:
This pull request is to make the file copying conditional and unblock any build breaks due to the limitation. And please consider to back-port to
kinetic-devel
as well.