[Windows] offload source spaces into order_paths.py #1113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One limitation of Windows command processor is that the full command line cannot exceed 8191 characters. And in the code path where
catkin
sorts a list of paths, it is passing all the workspaces plus source spaces by command line toorder_paths.py
. When the workspaces is huge enough, it will render as an error -The command line is too long.
.To workaround this limitation, this patch is proposing to synthesize the source spaces in
order_paths.py
instead of passing the long string by command line.Also, please consider to back-port to
kinetic-devel
if it makes sense. Thanks!