[Windows] execute the output of _setup_util.py in place #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review. |
|
@dirk-thomas Please excuse me pinging you on this. This is ready for review and merge. We have seen some folks using |
|
Thanks for the patch. |
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 26, 2020
|
Cherry-picked to |
|
Thanks for the quick response! |
seanyen
added a commit
to ms-iot/catkin
that referenced
this pull request
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When different isolated
setup.batare invoked at the same time (for example, when building in parallel withcolcon), the_SETUP_TMPhas chances to end up with the same file path (the file name is generated by%Time: =0%and it doesn't give a good quality for uniqueness). And in this case, the file write (creation) and deletion can race together and result in unexpected errors.This pull request is to address this problem by removing the need of the intermediate temp file and execute the generated batch commands in place directly.
Also, please consider to back-port to kinetic-devel if it makes sense. Thanks!