count 'skipped' tests as skipped #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only 'skip' and 'disabled' were counted as skipped tests. However, junit format explicitly allows 'skipped' (cmp. https://github.com/windyroad/JUnit-Schema/blob/master/JUnit.xsd#L196) For reference, also see the same issue in colcon: - Bug: colcon/colcon-test-result#18 - PR: colcon/colcon-test-result#19
|
Thanks for the patch. Yes, support for |
dirk-thomas
pushed a commit
that referenced
this pull request
Sep 28, 2020
Previously only 'skip' and 'disabled' were counted as skipped tests. However, junit format explicitly allows 'skipped' (cmp. https://github.com/windyroad/JUnit-Schema/blob/master/JUnit.xsd#L196) For reference, also see the same issue in colcon: - Bug: colcon/colcon-test-result#18 - PR: colcon/colcon-test-result#19
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only 'skip' and 'disabled' were counted as skipped tests.
However, junit format explicitly allows 'skipped' (cmp.
https://github.com/windyroad/JUnit-Schema/blob/master/JUnit.xsd#L196)
For reference, also see the same issue in colcon:
This is based on noetic-devel, but applies to kinetic-devel as well (particularly, we are facing this issue under melodic and would appreciate a backport (or shall I create a new PR?))