Make plain cmake install to devel when --install not present #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added a commit
that referenced
this pull request
Jan 12, 2013
Make plain cmake install to devel when --install not present
cwecht
pushed a commit
to cwecht/catkin
that referenced
this pull request
Mar 20, 2018
- Among the lines added in ros#150, the one that fixes building with Qt5 is the following line: include_directories(${Qt5Widgets_INCLUDE_DIRS}) The rest is redundant and actually doesn't do anything. A CMake variable named QtX_INCLUDE_DIRS is not defined when find_package()-ing Qt. Also, there is no need to find_package() Qt5 Widgets twice. - In documentation, add sudo to rosdep init invocation, following http://wiki.ros.org/rosdep. Add a comment about the error which will be printed if the user has already run sudo rosdep init since installing ROS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.