-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catkin_prepare_release should validate metapackages #404
Conversation
It should also check that the |
@dirk-thomas and @tfoote for review |
Error output looks something like this:
Or
The extra |
+1 |
metapackage.validate_metapackage(path, package, warnings=True) | ||
except metapackage.InvalidMetapackage as e: | ||
print("Invalid metapackage at path '%s':\n %s\n" % (os.path.abspath(path), str(e))) | ||
print("See requirements for metapackages: %s" % metapackage.DEFINITION_URL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these error message be printed to , file=sys.stderr
?
@dirk-thomas updated for review again. |
+1 |
I will wait to merge this until ros-infrastructure/catkin_pkg#40 is merged and catkin_pkg 0.1.11 is released. |
catkin_prepare_release should validate metapackages
Specifically that they have valid
CMakeLists.txt
. A lot of people are going to run into this problem while releasing with bloom. It would be nice to have this tool check.It could output:
Instead of its normal command output, which would be safe for people doing something like this: