Fix for Python3.2 compatibility #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added a commit
that referenced
this pull request
Jul 24, 2013
Fix for Python3.2 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation breaks compatibility with Python3.2. This simple fix should work for all Python versions between 2.7 and 3.3 making catkin usable in all these versions.
Unittest works for Python2.7, however it does not work for Python3. I did not adapt the unittest towards Python3 since I guess it is meant for Python2.7 and porting unit tests to Python3 is a whole other topic which should probably be addressed somewhen in the future...