python 3 compatibility #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
| line = proc.stdout.readline().decode('utf8', 'replace') | ||
| try: | ||
| line = unicode(line) | ||
| except NameError: |
There was a problem hiding this comment.
This is awkward, It might be worth a comment that this is for python2 backwards compatability so that sometime in the future we would come back and clear all backwards compatibility things out.
Maybe we should be flagging everything like that with a unique string for ease of finding.
There was a problem hiding this comment.
Added note in 0436f6c.
|
+1 pending comments |
|
+1 |
1 similar comment
|
+1 |
dirk-thomas
added a commit
that referenced
this pull request
Nov 27, 2013
dirk-thomas
added a commit
that referenced
this pull request
Dec 4, 2013
dirk-thomas
added a commit
that referenced
this pull request
Dec 12, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tfoote @wjwwood Please review.