added atomic_configure_file function to catkin #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to #330. |
| @@ -46,6 +46,8 @@ | |||
| # | |||
| # @public | |||
| # | |||
| include(${catkin_EXTRAS_DIR}/atomic_configure_file.cmake) | |||
There was a problem hiding this comment.
Instead of including the file in multiple location please add it to the global list of included files: https://github.com/ros/catkin/blob/groovy-devel/cmake/all.cmake#L100
|
Ok, I addressed each of the concerns. |
Also made catkin use it in a few places. This was done to prevent errors when building multiple catkin packages into the same devel space in parallel.
|
Squashed. |
|
+1 |
dirk-thomas
added a commit
that referenced
this pull request
Dec 23, 2013
added atomic_configure_file function to catkin
dirk-thomas
added a commit
that referenced
this pull request
Dec 24, 2013
cwecht
pushed a commit
to cwecht/catkin
that referenced
this pull request
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also made catkin use it in a few places. This was done to prevent errors when building multiple catkin packages into the same devel space in parallel.