Fixed bug with length calculation #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed build errors like below: -- Using CATKIN_TEST_RESULTS_DIR: ~/ros_catkin_ws/build_isolated/rqt_image_view/test_results -- Found gtest sources under '/usr/src/gtest': gtests will be built -- catkin 0.5.84 CMake Error at /opt/ros/hydro_custom/share/catkin/cmake/catkin_package.cmake:399 (string): string end index: 57 is out of range -1 - 56
|
Thank you for catching this case. The suffix must be there to avoid matching two paths like |
dirk-thomas
added a commit
that referenced
this pull request
Feb 28, 2014
Fixed bug with length calculation
cwecht
pushed a commit
to cwecht/catkin
that referenced
this pull request
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the string length is calculated with an additional '/' it is necessary to add this character as well to the substring creation. If not it is possible to get out of range errors like below. Another possibility would be to remove the extra '/' from the length calculation in line 396 and 397, but I do not know if this has any side effects
Fixed build errors like below:
-- Using CATKIN_TEST_RESULTS_DIR:
~/ros_catkin_ws/build_isolated/rqt_image_view/test_results
-- Found gtest sources under '/usr/src/gtest': gtests will be built
-- catkin 0.5.84
CMake Error at
/opt/ros/hydro/share/catkin/cmake/catkin_package.cmake:399
(string):
string end index: 57 is out of range -1 - 56