"Notify" user of a cyclic package dependency #607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's too bad a lot of useful information was lost inside `topological_order.py` but still better than _just_ an `AttributeError`. Still looking for other places that need to check for this...
|
Thanks for reporting the problem. Your pull request won't be merged as-is due to the inappropriate commend and the lack of printing the actual package names involved in the circular dependency which makes it less value for the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's too bad a lot of useful information was lost inside
topological_order.pybut still better than just anAttributeError.Still looking for other places that need to check for this...